Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConstructClientExample #523

Merged
merged 9 commits into from
Oct 16, 2023
Merged

Add ConstructClientExample #523

merged 9 commits into from
Oct 16, 2023

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds the ConstructClientExample, which shows users the various ways to construct a Client.

  • Add fromConfig and fromConfigFile methods to Client, so that a Client can be configured from a file.
  • Add fromStringDer and fromBytesDer to PrivateKey so a PrivateKey can be constructed from a file.

Related issue(s):

Fixes #521

Notes for reviewer:
This PR contains work from #519, so that PR should be reviewed and merged first.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Oct 11, 2023
@rwalworth rwalworth requested a review from deyanzz October 11, 2023 21:54
@rwalworth rwalworth self-assigned this Oct 11, 2023
@rwalworth rwalworth linked an issue Oct 11, 2023 that may be closed by this pull request
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT.

@deyanzz deyanzz requested a review from gsstoykov October 16, 2023 06:58
@deyanzz deyanzz merged commit 0e1198f into main Oct 16, 2023
2 checks passed
@deyanzz deyanzz deleted the 00521-add-constructclientexample branch October 16, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ConstructClientExample
3 participants