-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConstructClientExample
#523
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…-consensuspubsubwithsubmitkeyexample Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…ent from a JSON configuration Signed-off-by: Rob Walworth <[email protected]>
rwalworth
added
the
New Feature
A new feature, service, or documentation. Major changes that are not backwards compatible.
label
Oct 11, 2023
Signed-off-by: Rob Walworth <[email protected]>
deyanzz
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT.
Signed-off-by: Deyan Zhekov <[email protected]>
gsstoykov
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Feature
A new feature, service, or documentation. Major changes that are not backwards compatible.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
ConstructClientExample
, which shows users the various ways to construct aClient
.fromConfig
andfromConfigFile
methods toClient
, so that aClient
can be configured from a file.fromStringDer
andfromBytesDer
toPrivateKey
so aPrivateKey
can be constructed from a file.Related issue(s):
Fixes #521
Notes for reviewer:
This PR contains work from #519, so that PR should be reviewed and merged first.
Checklist